Merged
Conversation
sergio-costas
force-pushed
the
fix-bash-comparison
branch
from
03a939c to
67a47b2
Compare
nteodosio
approved these changes
Mar 26, 2025
nteodosio
left a comment
nteodosio
left a comment
There was a problem hiding this comment.
I'd go for the portable syntax [ "$session_type" = "KDE" ], but the script is #!/bin/bash so this is good too.
Author
|
You are right... better use the portable way. I'll change it. |
This patch fixes a warning from Bash
sergio-costas
force-pushed
the
fix-bash-comparison
branch
from
b8c8682 to
14091c5
Compare
|
FYI, it would have been nice to use quoted variables too, just in case |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bash complains that == is being used where = should be. To use ==, double brackets must be used.